Skip to content

Fix lspFrame.source NPE on stackTrace request #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chagong merged 2 commits into from
Dec 9, 2025
Merged

Fix lspFrame.source NPE on stackTrace request #616

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b616b3
Fix lspFrame.source NPE on stackTrace request
mfussenegger Dec 4, 2025
6aef4b6
Fix line number comparison in StackTraceRequestHandler
chagong Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...src/main/java/com/microsoft/java/debug/core/adapter/handler/StackTraceRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
import com.google.gson.JsonObject;
import com.microsoft.java.debug.core.AsyncJdwpUtils;
import com.microsoft.java.debug.core.DebugSettings;
import com.microsoft.java.debug.core.DebugSettings.Switch;
import com.microsoft.java.debug.core.DebugUtility;
import com.microsoft.java.debug.core.IBreakpoint;
import com.microsoft.java.debug.core.DebugSettings.Switch;
import com.microsoft.java.debug.core.adapter.AdapterUtils;
import com.microsoft.java.debug.core.adapter.IDebugAdapterContext;
import com.microsoft.java.debug.core.adapter.IDebugRequestHandler;
Expand All @@ -40,13 +40,13 @@
import com.microsoft.java.debug.core.adapter.SourceType;
import com.microsoft.java.debug.core.adapter.formatter.SimpleTypeFormatter;
import com.microsoft.java.debug.core.adapter.variables.StackFrameReference;
import com.microsoft.java.debug.core.protocol.Events.TelemetryEvent;
import com.microsoft.java.debug.core.protocol.Messages.Response;
import com.microsoft.java.debug.core.protocol.Requests.Arguments;
import com.microsoft.java.debug.core.protocol.Requests.Command;
import com.microsoft.java.debug.core.protocol.Requests.StackTraceArguments;
import com.microsoft.java.debug.core.protocol.Responses;
import com.microsoft.java.debug.core.protocol.Types;
import com.microsoft.java.debug.core.protocol.Events.TelemetryEvent;
import com.sun.jdi.AbsentInformationException;
import com.sun.jdi.IncompatibleThreadStateException;
import com.sun.jdi.LocalVariable;
Expand Down Expand Up @@ -114,7 +114,7 @@ public CompletableFuture<Response> handle(Command command, Arguments arguments,
result.add(lspFrame);
frameReference.setSource(lspFrame.source);
int jdiLineNumber = AdapterUtils.convertLineNumber(jdiFrame.lineNumber, context.isDebuggerLinesStartAt1(), context.isClientLinesStartAt1());
if (jdiLineNumber != lspFrame.line) {
if (jdiLineNumber != lspFrame.line && lspFrame.source != null) {
Copy link
Copy Markdown
Contributor Author

@mfussenegger mfussenegger Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also change convertLineNumber to return 0 as is?
No idea what other implications that might have.

Copy link
Copy Markdown
Contributor

@chagong chagong Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be safe to merge, but I will test a little bit for different cases.

decompiledClasses.add(lspFrame.source.path);
}
}
Expand Down