Simplify pinned-column wording, preserve demo page metadata, and remove tracked generated props file#4673
Draft
Copilot wants to merge 8 commits intocopilot/research-fluentdatagrid-implementationfrom
Conversation
…x to PinOffset (string) with logical CSS properties Agent-Logs-Url: https://github.com/microsoft/fluentui-blazor/sessions/705a5b7c-1768-42a0-ba5f-faa99daf78d4 Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
…gitignore Agent-Logs-Url: https://github.com/microsoft/fluentui-blazor/sessions/705a5b7c-1768-42a0-ba5f-faa99daf78d4 Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/fluentui-blazor/sessions/e324508b-d7f0-40e2-bfec-a2707d42806c Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/fluentui-blazor/sessions/e324508b-d7f0-40e2-bfec-a2707d42806c Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/fluentui-blazor/sessions/9d4563a7-5f41-4b62-ab85-0d78d50060b1 Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
vnbaaij
April 4, 2026 15:46
View session
vnbaaij
requested changes
Apr 4, 2026
Comment on lines
-1
to
-5
| --- | ||
| title: Pinned columns | ||
| order: 0095 | ||
| route: /DataGrid/PinnedColumns | ||
| --- |
Collaborator
There was a problem hiding this comment.
This needs to stay in place. Is used for the demo site nav menu
Contributor
Author
There was a problem hiding this comment.
Fixed in a0f46eb by restoring the page front matter (title and route) so the demo nav/menu registration stays intact.
Comment on lines
+61
to
+62
| * Column resizing interacts correctly with sticky offsets — the JavaScript in | ||
| `FluentDataGrid.razor.ts` recalculates `left` / `right` values after every resize step via | ||
| `FluentDataGrid.razor.ts` recalculates start and end offset values after every resize step via |
Collaborator
There was a problem hiding this comment.
This is too much detail. It is not necessary for the developer using the component to know this
Contributor
Author
There was a problem hiding this comment.
Updated in a0f46eb to remove the implementation detail and keep the note user-focused.
Agent-Logs-Url: https://github.com/microsoft/fluentui-blazor/sessions/bbc46172-3499-4123-a119-cc10c435de7f Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/fluentui-blazor/sessions/bbc46172-3499-4123-a119-cc10c435de7f Co-authored-by: vnbaaij <1761079+vnbaaij@users.noreply.github.com>
Copilot
AI
changed the title
Simplify pinned-column wording to start/end and remove tracked generated props file
Simplify pinned-column wording, preserve demo page metadata, and remove tracked generated props file
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
This PR updates the pinned-columns documentation to use plain
start/endwording, preserves the demo page metadata required for the demo site navigation, and removes an accidentally tracked generated file undersrc/Core.Scripts/obj.Pinned column docs/comments
inline-start,inline-end,inset-inline-start, andinset-inline-endStart/Endsemantics, while preserving current runtime behaviorGenerated file cleanup
src/Core.Scripts/obj\Debug/\package.g.propsfrom source control🎫 Issues
👩💻 Reviewer Notes
Review the pinned-columns documentation updates and the single-file repository cleanup. No behavioral change is intended.
📑 Test Plan
BLAZOR106error forexamples/Demo/FluentUI.Demo.Client/Documentation/General/Spacing/Examples/SpacingComputedBoxes.razor.js✅ Checklist
General
Component-specific
MCP Server
⏭ Next Steps