Localize Aspire skills metadata errors#17547
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17547Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17547" |
14 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR localizes Aspire skills embedded-bundle metadata validation failures in the Aspire CLI by routing previously hard-coded installer/verification messages through AgentCommandStrings and updating the generated localization files.
Changes:
- Replaced hard-coded embedded skills metadata/verification failure strings with
AgentCommandStringsresources. - Added new
AgentCommandStringsresource entries and refreshed the generated designer. - Updated the
AgentCommandStrings.*.xlffiles with the new resource IDs.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Cli/Agents/AspireSkills/AspireSkillsInstaller.cs | Switches embedded metadata/hash validation messages to localized resources. |
| src/Aspire.Cli/Resources/AgentCommandStrings.resx | Adds new resource strings for embedded skills metadata/hash validation failures. |
| src/Aspire.Cli/Resources/AgentCommandStrings.Designer.cs | Updates the generated resource accessor properties for the new strings. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.cs.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.de.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.es.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.fr.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.it.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.ja.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.ko.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.pl.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.pt-BR.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.ru.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.tr.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.zh-Hans.xlf | Adds new trans-units for the new resource IDs. |
| src/Aspire.Cli/Resources/xlf/AgentCommandStrings.zh-Hant.xlf | Adds new trans-units for the new resource IDs. |
Files not reviewed (1)
- src/Aspire.Cli/Resources/AgentCommandStrings.Designer.cs: Language not supported
davidfowl
approved these changes
May 27, 2026
Contributor
|
❓ CLI E2E Tests unknown — 107 passed, 0 failed, 2 unknown (commit View all recordings
📹 Recordings uploaded automatically from CI run #26522230598 |
aspire-repo-bot Bot
added a commit
to microsoft/aspire.dev
that referenced
this pull request
May 27, 2026
…r page Documents the error messages that can appear when aspire agent init encounters an invalid or corrupt embedded skills bundle, and explains the resolution steps (update or reinstall the Aspire CLI). Related: microsoft/aspire#17547 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Pull request created: #1098
|
Contributor
|
📝 Documentation has been drafted in microsoft/aspire.dev#1098 targeting Added a Skills bundle errors troubleshooting subsection to Note This draft PR needs human review before merging. |
pull Bot
pushed a commit
to tooniez/aspire
that referenced
this pull request
Jun 2, 2026
Brings 43 release-branch commits forward onto main now that 13.4.0 has shipped. This PR replaces the original automated merge (microsoft#17804) which had to be closed so that conflict resolution and post-merge cleanups could be made on a non-protected branch. Conflict resolution summary (33 files): * Equivalent backports (took main's commit identity): ChannelUpdateWorkflowTests, LoggingHelpersTests, the four extension test files, AspireEditorCommandProvider, appHostDiscovery. * Release-only forwards (preserved): microsoft#17732 / microsoft#17756 Foundry hosted-agent protocol selection and cross-compute-environment endpoint references, microsoft#17573 stabilize PrebuiltAppHostServer staging globalPackagesFolder path, microsoft#17743 staging-identity CLI darc feed routing. * Main-only forwards (preserved): microsoft#17506 Show discovered AppHosts in Aspire pane, microsoft#17547 Localize Aspire skills metadata errors, microsoft#17801 VS Code v1.12.0, microsoft#17297 Aspire CLI npm package release integration, microsoft#17576 TerminalRun IAsyncDisposable, microsoft#17721 / microsoft#17723 VS Code telemetry, microsoft#17671 ATS baseline fix (re-applied manually on top of Foundry source taken from release). * Hybrid (manually spliced): docs/contributing.md - kept main's restructured layout and inserted release's staging-validation paragraph; HostedAgentBuilder- Extension - took release base then re-applied microsoft#17671 asHostedAgent rename; UpdateCommandTests - took main and injected microsoft#17743's OverrideCliInformationalVersionConfigKey block. Post-merge cleanups included in this PR: * eng/Versions.props: revert StabilizePackageVersion to false (was flipped to true on release/13.4 by microsoft#17520 for shipping 13.4.0; main must stay in preview mode). * .github/workflows/generate-api-diffs.yml: retarget back to main (was pointed at release/13.4 by microsoft#17696 release prep). * .github/workflows/backmerge-release.yml: update from release/13.3 to release/13.4 (was stale - missed the 13.4 release-time bump). * .github/workflows/milestone-assignment.yml: audited - already correct (main -> 13.5, release/13.4 -> 13.4.x); no change. This merge commit must be preserved - do not squash on merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Localizes the embedded Aspire skills bundle metadata validation failures discussed in #17537 (comment). The hard-coded metadata and archive verification messages now flow through
AgentCommandStrings, andUpdateXlfadded the corresponding entries for the CLI localization files.Validation:
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?