Skip to content

Refactor DefPointerList with compliant C++ #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Trung Nguyen (trungnt2910) wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Refactor DefPointerList with compliant C++ #6663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dev/MRTCore/mrt/mrm/include/mrm/build/DefList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,8 @@ class DefList : public DefObject
template<typename VALUE, typename CallBackCompareFunc = VoidComparerFunc, typename CallbackHashFunc = VoidHashFunc>
class DefPointerList : public DefList<VALUE*, CallBackCompareFunc, CallbackHashFunc>
{
private:
using Base = DefList<VALUE*, CallBackCompareFunc, CallbackHashFunc>;
public:
static HRESULT CreateInstance(_Outptr_ DefPointerList<VALUE, CallBackCompareFunc, CallbackHashFunc>** result)
{
Expand Down Expand Up @@ -607,10 +609,10 @@ class DefPointerList : public DefList<VALUE*, CallBackCompareFunc, CallbackHashF

virtual ~DefPointerList()
{
for (int i = 0; i < DefList::Count(); i++)
for (int i = 0; i < Base::Count(); i++)
{
const VALUE* pMember = nullptr;
if (TryGetValue(i, &pMember))
if (Base::TryGetValue(i, &pMember))
{
delete (pMember);
}
Expand Down
Loading