Enhance and organize test execution#40108
Open
AmelBawa-msft wants to merge 12 commits intofeature/wsl-for-appsfrom
Open
Enhance and organize test execution#40108AmelBawa-msft wants to merge 12 commits intofeature/wsl-for-appsfrom
AmelBawa-msft wants to merge 12 commits intofeature/wsl-for-appsfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the WSLC Windows E2E test suite by splitting previously co-located container tests into dedicated files and adds additional coverage for container run/exec behaviors (env vars/files, ports, interactive scenarios).
Changes:
- Added
WSLCExecutionResult::StdoutContainsLine()and new shared helper functions (WriteFile,GetPythonHttpServerScript) to reduce repeated test logic. - Introduced new E2E test classes/files for
container execandcontainer attach, and expandedcontainer runtests (env/env-file and port mapping cases). - Removed the migrated tests and local helper utilities from
WSLCE2EContainerCreateTests.cpp.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/wslc/e2e/WSLCExecutor.h | Adds StdoutContainsLine() to the execution result helper API. |
| test/windows/wslc/e2e/WSLCExecutor.cpp | Implements StdoutContainsLine() for line-based stdout assertions. |
| test/windows/wslc/e2e/WSLCE2EHelpers.h | Declares new shared helpers for file-writing and python http server command generation. |
| test/windows/wslc/e2e/WSLCE2EHelpers.cpp | Implements new shared helpers formerly embedded in CreateTests. |
| test/windows/wslc/e2e/WSLCE2EContainerRunTests.cpp | Adds/relocates container run tests (env/env-file, ports, interactive). |
| test/windows/wslc/e2e/WSLCE2EContainerExecTests.cpp | New file containing container exec E2E tests. |
| test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp | Removes migrated run/exec/port tests and local helper utilities. |
| test/windows/wslc/e2e/WSLCE2EContainerAttachTests.cpp.cpp | New file containing container attach E2E tests (note: filename issue raised in comments). |
Member
|
Tried converting to draft to get the dynamic / submit-nuget task to go away, it did not... |
Member
|
Might have to re-create (or I will override gates), sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
container attachtests fromWSLCE2EContainerCreateests.cpptoWSLCE2EContainerAttachTests.cppcontainer exectests fromWSLCE2EContainerCreateTests.cpptoWSLCE2EContainerExecTests.cppcontainer runtests fromWSLCE2EContainerCreateTests.cpptoWSLCE2EContainerRunTests.cppS_OKwith0