Skip to content

Release COM DLLs before installer test MSI operations #40093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benhillis merged 2 commits into from
Apr 3, 2026
Merged

Release COM DLLs before installer test MSI operations #40093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb60108
Release COM DLLs before installer test MSI operations
Apr 3, 2026
ec0ea01
fix CoFreeUnusedLibrariesEx
Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/windows/InstallerTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,17 @@ class InstallerTests
return wsl::windows::common::registry::ReadString(m_lxssKey.get(), L"MSI", L"ProductCode", L"");
}

// Release any in-process COM DLLs (e.g. wslserviceproxystub.dll loaded by prior tests)
// so the Restart Manager doesn't detect the test process as holding files.
// This avoids install failures on older Server SKUs where the RM has stricter silent-mode behavior.
static void PrepareForMsiOperation()
{
CoFreeUnusedLibrariesEx(0, 0);
}

void UninstallMsi()
{
PrepareForMsiOperation();
auto productCode = GetMsiProductCode();
VERIFY_IS_FALSE(productCode.empty());

Expand All @@ -185,6 +194,7 @@ class InstallerTests

void InstallMsi()
{
PrepareForMsiOperation();
CallMsiExec(std::format(L"/qn /norestart /i {} /L*V {}", m_msiPath, GenerateMsiLogPath()));
}

Expand Down Expand Up @@ -367,6 +377,7 @@ class InstallerTests
LogInfo("Installing: %ls", installerFile.c_str());
if (wsl::shared::string::EndsWith<wchar_t>(installerFile, L".msi"))
{
PrepareForMsiOperation();
CallMsiExec(std::format(L"/qn /norestart /i {} /L*V {}", installerFile, GenerateMsiLogPath()));
}
else
Expand Down