Skip to content

Update WSLCCreateSession event to critical.#40065

Merged
craigloewen-msft merged 7 commits intofeature/wsl-for-appsfrom
user/crloewen/telemetry-fix
Apr 7, 2026
Merged

Update WSLCCreateSession event to critical.#40065
craigloewen-msft merged 7 commits intofeature/wsl-for-appsfrom
user/crloewen/telemetry-fix

Conversation

@craigloewen-msft
Copy link
Copy Markdown
Member

Quick PR to update the WSLCCreateSession event to critical.](#40064)

@craigloewen-msft craigloewen-msft requested a review from a team as a code owner April 1, 2026 19:46
Copilot AI review requested due to automatic review settings April 1, 2026 19:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the WSLCCreateSession TraceLogging event emitted by the WSL service during session creation, aiming to classify it as “critical” telemetry data.

Changes:

  • Replaced WSL_LOG_TELEMETRY with WSL_LOG for WSLCCreateSession.
  • Tagged the event with MICROSOFT_KEYWORD_CRITICAL_DATA and set an explicit WINEVENT_LEVEL_INFO.
  • Switched the privacy tag from PDT_ProductAndServiceUsage to PDT_ProductAndServicePerformance.

Copilot AI review requested due to automatic review settings April 3, 2026 01:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@benhillis
Copy link
Copy Markdown
Member

Hey @craigloewen-msft 👋 — Following up on this PR. CI is all green and it's a small change. There's 1 unresolved review thread — the Copilot reviewer flagged the privacy tag change from \PDT_ProductAndServiceUsage\ to \PDT_ProductAndServicePerformance\. Could you confirm whether this classification change is intentional? That should unblock this.

Copilot AI review requested due to automatic review settings April 7, 2026 16:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 7, 2026 18:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

@craigloewen-msft craigloewen-msft merged commit e5d589d into feature/wsl-for-apps Apr 7, 2026
11 checks passed
@craigloewen-msft craigloewen-msft deleted the user/crloewen/telemetry-fix branch April 7, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants