[WSLC] Add 'wslc version' subcommand by ptrivedi · Pull Request #14547 · microsoft/WSL

ptrivedi · 2026-03-26T20:05:59Z

Summary of the Pull Request

Adds a version subcommand to the WSLC CLI so users can run wslc version in addition to the existing wslc --version flag. This follows the subcommand pattern used by other WSLC commands.

Changes

commands/VersionCommand.h / commands/VersionCommand.cpp — new VersionCommand that prints wslc v<version>
commands/RootCommand.cpp — registers VersionCommand as a subcommand of the root

Tests

CommandLineTestCases.h — parsing test cases for wslc version, wslc version --help, and invalid usage
WSLCCLICommandUnitTests.cpp — unit tests verifying command name, no subcommands, no extra arguments, and presence in root command's subcommand list

Validation Steps Performed

Verified manually that wslc version prints the version string identically to wslc --version.

TODO

Discuss and decide with the team whether wslc --version can be removed now that wslc version exists.

🤖 Generated with Claude Code

Adds a 'version' subcommand to the WSLC CLI as an alternative to the existing '--version' flag, following the subcommand pattern used by other WSLC commands. Includes unit tests for command structure and command-line parsing. Co-authored-by: Pooja Trivedi <trivedipooja@microsoft.com> Co-Authored-By: Claude Sonnet 4.6

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

AmelBawa-msft · 2026-03-27T15:37:52Z

LGTM! I suspect the E2E test will fail for WSLCE2EGlobalTests class because we need to update the help message and potentially add some E2E tests for version (e.g. ensure returns exit code 0, the expected version in stdout, empty string in stderr).

e.g.

RunWslcAndVerify("version", { .Stdout = std::format(L"{} v{}", ..., ...),  .Stderr = L"",  .ExitCode = 0});

…dition Update expected help output in WSLCE2EGlobalTests to include the newly added 'version' subcommand, fixing WSLCE2E_HelpCommand and WSLCE2E_InvalidCommand_DisplaysErrorMessage test failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

test/windows/wslc/WSLCCLICommandUnitTests.cpp

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

src/windows/wslc/commands/VersionCommand.cpp

test/windows/wslc/WSLCCLICommandUnitTests.cpp

- Add WSLCE2E_VersionCommand E2E test in WSLCE2EGlobalTests verifying stdout, empty stderr, and exit code for 'wslc version' - Add assertion to VersionCommand_HasNoArguments unit test to verify only the auto-added --help argument is present Authored-By: Pooja Trivedi <trivedipooja@microsoft.com> Co-Authored-By: Claude Sonnet 4.6

ptrivedi · 2026-03-29T04:09:24Z

LGTM! I suspect the E2E test will fail for WSLCE2EGlobalTests class because we need to update the help message and potentially add some E2E tests for version (e.g. ensure returns exit code 0, the expected version in stdout, empty string in stderr).

e.g.
RunWslcAndVerify("version", { .Stdout = std::format(L"{} v{}", ..., ...),  .Stderr = L"",  .ExitCode = 0});

Added this, @AmelBawa-msft, PTAL

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

VersionCommand::ExecuteInternal to avoid build issues

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

src/windows/wslc/commands/VersionCommand.cpp

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp

src/windows/wslc/commands/VersionCommand.cpp

- Use Localization::WSLCCLI_VersionDesc/LongDesc instead of hard-coded strings; add entries to en-US Resources.resw - Centralize version printing in VersionCommand::PrintVersion(); reuse from RootCommand --version flag - Drop 'v' prefix from version output per OneBlue's feedback - Add 'version' entry to E2E GetAvailableCommands() to fix WSLCE2E_HelpCommand and WSLCE2E_InvalidCommand_DisplaysErrorMessage Co-Authored-By: Pooja Trivedi

…ptrivedi/cli-version

Localization::WSLCCLI_VersionDesc() and WSLCCLI_VersionLongDesc() live in wsl::shared::Localization. Without this using directive the compiler cannot resolve the unqualified Localization:: references in VersionCommand.cpp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

src/windows/wslc/commands/VersionCommand.cpp

src/windows/wslc/commands/RootCommand.cpp

…ptrivedi/cli-version

benhillis · 2026-04-07T02:42:19Z

Hey @ptrivedi 👋 — Following up on this PR. CI is passing, but there are 5 unresolved review threads:

E2E help test mismatch
Hard-coded English strings that need localization
Duplicated version formatting logic
\�\ prefix inconsistency
Missing \--version\ E2E coverage

Could you take a look at addressing these when you get a chance? Thanks!

ptrivedi · 2026-04-07T02:58:28Z

Hey @ptrivedi 👋 — Following up on this PR. CI is passing, but there are 5 unresolved review threads:

E2E help test mismatch

Hard-coded English strings that need localization

Duplicated version formatting logic

\�\ prefix inconsistency

Missing --version\ E2E coverage

Could you take a look at addressing these when you get a chance? Thanks!

Review threads have been resolved. Will merge this.

ptrivedi requested a review from a team as a code owner March 26, 2026 20:06

ptrivedi requested review from OneBlue, benhillis, Copilot, damanm24 and jstarks March 26, 2026 20:06

Copilot AI reviewed Mar 26, 2026

View reviewed changes

ptrivedi requested review from AmelBawa-msft and dkbennett and removed request for damanm24 and jstarks March 26, 2026 20:08

ptrivedi changed the base branch from master to feature/wsl-for-apps March 26, 2026 20:11

ptrivedi requested a review from a team as a code owner March 26, 2026 20:11

benhillis requested a review from Copilot March 26, 2026 20:27

Copilot started reviewing on behalf of benhillis March 26, 2026 20:28 View session

Copilot AI reviewed Mar 26, 2026

View reviewed changes

Merge branch 'feature/wsl-for-apps' into user/ptrivedi/cli-version

a81125a

Copilot AI review requested due to automatic review settings March 27, 2026 18:27

ptrivedi marked this pull request as draft March 27, 2026 18:28

Copilot started reviewing on behalf of ptrivedi March 27, 2026 18:30 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

test/windows/wslc/WSLCCLICommandUnitTests.cpp Show resolved Hide resolved

ptrivedi marked this pull request as ready for review March 29, 2026 03:15

Copilot AI review requested due to automatic review settings March 29, 2026 03:15

Copilot started reviewing on behalf of ptrivedi March 29, 2026 03:16 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

src/windows/wslc/commands/VersionCommand.cpp Show resolved Hide resolved

test/windows/wslc/WSLCCLICommandUnitTests.cpp Show resolved Hide resolved

ptrivedi force-pushed the user/ptrivedi/cli-version branch from 309d934 to 70b1e83 Compare March 29, 2026 04:04

Copilot AI review requested due to automatic review settings March 29, 2026 04:10

Copilot started reviewing on behalf of ptrivedi March 29, 2026 04:10 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Mark 'context' as UNREFERENCED_PARAMETER in

bf04c87

VersionCommand::ExecuteInternal to avoid build issues

ptrivedi force-pushed the user/ptrivedi/cli-version branch from 9afcebe to bf04c87 Compare March 29, 2026 04:23

Merge branch 'feature/wsl-for-apps' into user/ptrivedi/cli-version

86a999c

Copilot AI review requested due to automatic review settings March 29, 2026 04:25

Copilot started reviewing on behalf of ptrivedi March 29, 2026 04:26 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Merge branch 'feature/wsl-for-apps' into user/ptrivedi/cli-version

33ca5d1

OneBlue reviewed Mar 30, 2026

View reviewed changes

src/windows/wslc/commands/VersionCommand.cpp Outdated Show resolved Hide resolved

dkbennett approved these changes Mar 31, 2026

View reviewed changes

Merge branch 'feature/wsl-for-apps' into user/ptrivedi/cli-version

f8fa60f

Copilot AI review requested due to automatic review settings April 3, 2026 21:46

Copilot started reviewing on behalf of ptrivedi April 3, 2026 21:47 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp Show resolved Hide resolved

src/windows/wslc/commands/VersionCommand.cpp Outdated Show resolved Hide resolved

src/windows/wslc/commands/VersionCommand.cpp Show resolved Hide resolved

Pooja Trivedi and others added 3 commits April 3, 2026 20:15

Merge remote-tracking branch 'origin/feature/wsl-for-apps' into user/…

aa540ef

…ptrivedi/cli-version

Copilot AI review requested due to automatic review settings April 6, 2026 23:11

Copilot started reviewing on behalf of ptrivedi April 6, 2026 23:12 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

src/windows/wslc/commands/VersionCommand.cpp Show resolved Hide resolved

src/windows/wslc/commands/RootCommand.cpp Show resolved Hide resolved

Merge remote-tracking branch 'origin/feature/wsl-for-apps' into user/…

ea4e4d4

…ptrivedi/cli-version

ptrivedi merged commit 715ce52 into feature/wsl-for-apps Apr 7, 2026
7 checks passed

ptrivedi deleted the user/ptrivedi/cli-version branch April 7, 2026 02:59

Conversation

ptrivedi commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

Changes

Tests

Validation Steps Performed

TODO

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

AmelBawa-msft commented Mar 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

ptrivedi commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

benhillis commented Apr 7, 2026

Uh oh!

ptrivedi commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ptrivedi commented Mar 26, 2026 •

edited

Loading