Repository navigation
[FIX]: Fail pytest when a RAMPART trial gate fails - #114
Closed
Behnam (behnam-o) wants to merge 1 commit into
Closed
Behnam (behnam-o) wants to merge 1 commit into
Behnam (behnam-o) wants to merge 1 commit into
Conversation
Spencer Schoenberg (spencrr)
left a comment
Spencer Schoenberg (spencrr)
left a comment
Contributor
There was a problem hiding this comment.
Behnam (@behnam-o) Nina Chikanov (@nina-msft) Is this similar to #73 (comment) but also includes upgrading trial failures to exit status as well?
Spencer Schoenberg (spencrr)
changed the title
Spencer Schoenberg (spencrr)
approved these changes
Jul 16, 2026
Spencer Schoenberg (spencrr)
left a comment
Spencer Schoenberg (spencrr)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Behnam (@behnam-o)! While we still have trial clones, I think this fits with my mental model of RAMPART: any trial group that did not pass (UNSAFE > 0 || SAFE / ALL < SAFE_THRESHOLD) should raise pytest exit status to failed. Bashir Partovi (@bashirpartovi) thoughts here?
Contributor
Author
|
closing this in favor of the work the will re-layer the trials into the execution logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates failed aggregate trial gates to pytest’s exit status.
session.exitstatustoTESTS_FAILEDwhen any trial group fails.