Repository navigation
FIX: keep int32 and uint8 WAV formats in AudioFrequencyConverter - #3109
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 3 commits into
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 3 commits into
Utkarsh Bahuguna (u7k4rs6) wants to merge 3 commits into
Conversation
Richard Lundeen (richlundeen)
approved these changes
Oct 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3108.
Same approach as the volume/echo fix in #2933: shift around 128 for uint8, keep the input dtype, and clip integer output to its range. int16 and float input give the same samples as before.
Tests: int32 and uint8 at shift 0 come back unchanged with the same dtype, and at a quarter-period shift match the expected samples. 4 new cases fail on main. tests/unit/converter: 2073 passed.