Repository navigation
FIX: feed TAP the objective score, not an auxiliary one - #3104
Merged
Richard Lundeen (richlundeen) merged 2 commits intoOct 11, 2026
Merged
Richard Lundeen (richlundeen) merged 2 commits into
Richard Lundeen (richlundeen) merged 2 commits into
Conversation
Skip unidentified scores when selecting objective feedback and cover all combinations of legacy, auxiliary, and objective scores. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a0bb1555-a9fd-458e-8701-de4f2fe159f1
Richard Lundeen (richlundeen)
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3103.
_get_response_score_asyncnow picks the score whosescorer_class_identifiermatches the node's objective scorer, and returns "unavailable" if there isn't one, same as when there are no scores.Same repro on this branch feeds 0.2. Test: with an aux score stored first, the node returns the objective score, and with only an aux score it returns "unavailable". It fails on main. tests/unit/executor/attack/multi_turn: 434 passed.