Repository navigation
FIX: record the attack identity on ERROR attack results - #3097
Merged
Richard Lundeen (richlundeen) merged 2 commits intoOct 11, 2026
Merged
Richard Lundeen (richlundeen) merged 2 commits into
Richard Lundeen (richlundeen) merged 2 commits into
Conversation
Clear the per-run identifier callback after execution and log builder failures at warning level. Cover builder failures, generic strategies, reused contexts, and compound error identities. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: fcbdea79-a119-453f-a809-3fc2d2cec113
Richard Lundeen (richlundeen)
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3096.
The error handler is a separate object with no access to the strategy, so
execute_with_context_asyncnow leaves a small builder on the context, and_on_error_asyncuses it to stamp the sameAtomicAttackIdentifierthe completed paths record. The eval hash gets auto-stamped on save like for any other row.It's built lazily, and only on the error path. If building it fails, it logs at debug and saves the error row without it, as before, so an odd target identifier can't block saving the error.
Scenario runs still enrich only completed results with seed info, so their error rows get the plain attack identity, which is enough for class and technique filters. Enriching those too would need the executor to keep input indices for incomplete objectives, so I left that out.
Repro on this branch:
Test: a failing PromptSendingAttack's stored ERROR row is found by the class filter and carries the attack identity and eval hash. It fails on main. tests/unit/executor, scenario, analytics and backend: 5437 passed.