Repository navigation
FIX: give adaptive technique selection the run id on fresh runs - #3094
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3093.
ScenarioContextgetsscenario_result_id: the stored id on resume, or the id the new result will use on a fresh run.initialize_asyncpicks that id withuuid4()before building attacks and creates theScenarioResultwith it, so the id the attacks saw is the one that gets saved.context.scenario_result_idto the dispatcher instead ofself._scenario_result_id, which is still None at that point on a fresh run.Same repro on this branch:
Test: a seeded TextAdaptive run passes its own result id to the selector, and resuming it makes the same picks. It fails on main. tests/unit/scenario and backend: 3814 passed.