Repository navigation
FIX: store aware datetimes as UTC in UTCDateTime columns - #3090
Merged
Richard Lundeen (richlundeen) merged 1 commit intoOct 11, 2026
Merged
Conversation
Richard Lundeen (richlundeen)
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3089.
Adds
UTCDateTime.process_bind_param: aware values get converted to naive UTC before they're stored or compared. Naive values are still taken as UTC and pass through as before, and nothing changes in the schema.Filter bounds were already normalized by the callers, and they now go through the same conversion, so they stay consistent.
Tests: bind conversion (offset, naive, None), plus a SQLite round trip where a -07:00 message timestamp and seed
date_addedcome back as the same instant. The round trip fails on main. tests/unit/memory and models: 3285 passed (test_memory_migrations_head_commandfails locally on main too, missingbuild_scripts).