Repository navigation
FIX: keep Responses web search calls replayable and behind the answer - #3080
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Open
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Utkarsh Bahuguna (u7k4rs6) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3079.
web_search_callitem (id,status,action) instead of justtypeandid.typeandidcan't be made valid, so they're skipped with a warning instead of failing the whole request.get_value()is the answer again. Replay order doesn't change since top-level items are always emitted before the message item.Same repro as the issue on this branch:
The old tests pinned the
call_id/queryshape, so I moved them to the real one. New tests: the answer is the response value, the replayed item matches the SDK param fields, and a legacy row gets skipped. They fail on main. tests/unit/prompt_target, backend, executor and score: 8853 passed (4 MCP/tool files didn't collect locally becausehttpx2isn't installed; they don't touch this).I didn't rerun the notebook since it needs the OpenAI endpoint, so its saved output still shows the old order.