Repository navigation
MAINT: Fail CoPyRIT deployment pipeline when initialization fails - #3068
Open
Justin Song (jsong468) wants to merge 1 commit into
Open
Justin Song (jsong468) wants to merge 1 commit into
Justin Song (jsong468) wants to merge 1 commit into
Conversation
Contributor
|
The rest of this change looks good to me. I think we should reuse We can add |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, deployment could pass even when PyRIT initialization failed:
/api/healthchecks web-server liveness, not whether the runtime can accept runs and sends./api/readyendpoint that returns HTTP 200 when PyRIT is ready and HTTP 503 otherwise, with runtime state and the serving ACA revision.failed,restart-required, orstopping; otherwise poll within a five-minute budget. Connection failures, malformed responses, and timeouts cannot pass deployment./api/health, configuration recovery, and infrastructure-only deployment behavior. A failed deployment does not deliberately terminate the backend or automatically roll back the image/database.Tests and Documentation