Repository navigation
[BREAKING] FIX Reject empty dataset filter criteria - #2951
Open
Jaafer Rahmani (bIackr0se) wants to merge 3 commits into
Open
Jaafer Rahmani (bIackr0se) wants to merge 3 commits into
Jaafer Rahmani (bIackr0se) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Roman Lutz (romanlutz)
approved these changes
Oct 9, 2026
Roman Lutz (romanlutz)
changed the title
Roman Lutz (romanlutz)
marked this pull request as ready for review
October 10, 2026 05:14
Keep a single empty-criteria guard in _validate while retaining the actionable error and regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SeedDatasetFilter(criteria=[])accepts an empty OR-list, so catalog matching silently returns no datasets. RaiseValueErrorat construction and tell callers to omitcriteriafor an unconstrained filter.This changes the explicit empty-list case from an empty result to an exception. Non-empty criteria, flat filter arguments and omitted criteria retain their behavior.
Built-in catalog discovery:
criteria=[]ValueErrorSeedDatasetFilter()criteria=[SeedDatasetMetadata()]Fixes #2947.
Tests and Documentation
DID NOT RAISE; conflicting-arguments and unconstrained-filter controls pass.make unit-test, runningpytest -n 4 --dist=loadfile tests/unit/datasets): 4,946 passed.ty check pyrit, changed-file Ruff and formatting, and applicable source hooks passed.