Skip to content

Fix misspellings flagged by Optional Lint (misspell check)#2515

Merged
shaahji merged 2 commits into
mainfrom
copilot/fix-optional-lint-job
Jun 11, 2026
Merged

Fix misspellings flagged by Optional Lint (misspell check)#2515
shaahji merged 2 commits into
mainfrom
copilot/fix-optional-lint-job

Conversation

Copilot AI commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

The "Optional Lint" CI job was failing due to British English spellings detected by the misspell checker.

Corrected all flagged occurrences across four files:

  • olive/cli/model_package.pybehaviourbehavior (×5), recognisedrecognized (×1)
  • mcp/src/olive_mcp/jobs.pycancelledcanceled (×2, includes a status string value used in comparisons)
  • mcp/src/olive_mcp/tools.pycancelledcanceled (×6, includes status string values and log messages)
  • test/cli/test_model_package.pyhonourhonor (×1), recognisesrecognizes (×1)

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'Optional Lint' Fix misspellings flagged by Optional Lint (misspell check) Jun 11, 2026
Copilot AI requested a review from shaahji June 11, 2026 20:05
@shaahji shaahji marked this pull request as ready for review June 11, 2026 20:35
Copilot AI review requested due to automatic review settings June 11, 2026 20:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request resolves failures in the “Optional Lint” CI job’s misspell check (US locale) by converting a handful of British English spellings to their US equivalents across the CLI packaging code, the MCP server job/status implementation, and related tests/docs.

Changes:

  • Updated docstrings/comments in CLI packaging logic and its tests (e.g., behaviourbehavior, recognisedrecognized, honourhonor).
  • Normalized MCP server cancellation wording to US spelling, including the job status string value (cancelledcanceled) and associated user-facing messages.
  • Kept the MCP job lifecycle logic consistent by updating both the status assignment and the status comparison used to avoid overwriting a canceled job’s state.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
olive/cli/model_package.py Spelling fixes in docstrings/comments within model packaging logic.
mcp/src/olive_mcp/jobs.py Updates the cancellation status comparison to match the new canceled status string.
mcp/src/olive_mcp/tools.py Updates cancellation log/message text and returned status payloads to canceled.
test/cli/test_model_package.py Spelling fixes in test docstrings/comments.

@shaahji shaahji enabled auto-merge (squash) June 11, 2026 21:05
@shaahji shaahji merged commit 3b9d03d into main Jun 11, 2026
14 checks passed
@shaahji shaahji deleted the copilot/fix-optional-lint-job branch June 11, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants