Fix misspellings flagged by Optional Lint (misspell check)#2515
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'Optional Lint'
Fix misspellings flagged by Optional Lint (misspell check)
Jun 11, 2026
shaahji
approved these changes
Jun 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request resolves failures in the “Optional Lint” CI job’s misspell check (US locale) by converting a handful of British English spellings to their US equivalents across the CLI packaging code, the MCP server job/status implementation, and related tests/docs.
Changes:
- Updated docstrings/comments in CLI packaging logic and its tests (e.g.,
behaviour→behavior,recognised→recognized,honour→honor). - Normalized MCP server cancellation wording to US spelling, including the job status string value (
cancelled→canceled) and associated user-facing messages. - Kept the MCP job lifecycle logic consistent by updating both the status assignment and the status comparison used to avoid overwriting a canceled job’s state.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
olive/cli/model_package.py |
Spelling fixes in docstrings/comments within model packaging logic. |
mcp/src/olive_mcp/jobs.py |
Updates the cancellation status comparison to match the new canceled status string. |
mcp/src/olive_mcp/tools.py |
Updates cancellation log/message text and returned status payloads to canceled. |
test/cli/test_model_package.py |
Spelling fixes in test docstrings/comments. |
jambayk
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Optional Lint" CI job was failing due to British English spellings detected by the
misspellchecker.Corrected all flagged occurrences across four files:
olive/cli/model_package.py—behaviour→behavior(×5),recognised→recognized(×1)mcp/src/olive_mcp/jobs.py—cancelled→canceled(×2, includes a status string value used in comparisons)mcp/src/olive_mcp/tools.py—cancelled→canceled(×6, includes status string values and log messages)test/cli/test_model_package.py—honour→honor(×1),recognises→recognizes(×1)Checklist before requesting a review
lintrunner -a(Optional) Issue link