Copy of #2505#2513
Closed
shaahji wants to merge 3 commits into
Closed
Conversation
Introduces a context_lengths parameter that allows users to specify an explicit list of context lengths (CLs) to compile, bypassing the fixed CL set produced by multi_graph. The two options are mutually exclusive. Like multi_graph, context_lengths is HTP-only. Sets arn_cl_options.context_length directly on the builder when provided, falling through to the existing multi_graph path otherwise.
Attribute assignment on MagicMock does not appear in mock_calls, so the previous string-matching assertion was vacuously passing. Replace with PropertyMock + patch.object so the setter is actually tracked.
patch.object requires the attribute to already exist on the class; plain MagicMock has no multi_graph attribute. Create a unique subclass per test so type(mock_builder) is isolated, then attach PropertyMock directly to track setter calls correctly.
Collaborator
Author
|
Closing in favor of #2505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a context_lengths parameter that allows users to specify an explicit list of context lengths (CLs) to compile, bypassing the fixed CL set produced by multi_graph. The two options are mutually exclusive. Like multi_graph, context_lengths is HTP-only.
Sets arn_cl_options.context_length directly on the builder when provided, falling through to the existing multi_graph path otherwise.
Describe your changes
Checklist before requesting a review
lintrunner -a(Optional) Issue link