COPY of #2486#2512
Draft
shaahji wants to merge 1 commit into
Draft
Conversation
shutil.copytree does not accept ignore_errors, so any caller passing copy_dir(..., ignore_errors=True) would raise TypeError at runtime. The kwarg was silently swallowed by mocks before mockey autospec enforcement surfaced the mismatch. Promote ignore_errors to an explicit parameter on copy_dir and use it to control RuntimeError suppression in the shutil.Error handler. Also adds mockey to test requirements and initializes patch_mock_module() in test/__init__.py to enforce mock call signatures across the test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutil.copytree does not accept ignore_errors, so any caller passing copy_dir(..., ignore_errors=True) would raise TypeError at runtime. The kwarg was silently swallowed by mocks before mockey autospec enforcement surfaced the mismatch.
Promote ignore_errors to an explicit parameter on copy_dir and use it to control RuntimeError suppression in the shutil.Error handler.
Also adds mockey to test requirements and initializes patch_mock_module() in test/init.py to enforce mock call signatures across the test suite.
Describe your changes
Checklist before requesting a review
lintrunner -a(Optional) Issue link