Skip to content

Debug logging of signature application #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achamayou wants to merge 3 commits into
base: main
Choose a base branch
from
+33 −2
Open

Debug logging of signature application #7803

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4737a86
Log TxID and iat timestamp when verifying backup COSE signatures
achamayou Apr 2, 2026
dad03da
Guard COSE header parsing with log level check
achamayou Apr 2, 2026
3a6cd92
Merge branch 'main' into debug_logging_of_signature_application
achamayou Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions src/node/history.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#pragma once

#include "ccf/crypto/cose_verifier.h"
#include "ccf/ds/x509_time_fmt.h"
#include "ccf/pal/locking.h"
#include "ccf/service/tables/nodes.h"
#include "ccf/service/tables/service.h"
Expand All @@ -15,6 +16,7 @@
#include "endian.h"
#include "kv/kv_types.h"
#include "kv/store.h"
#include "node/cose_common.h"
#include "node_signature_verify.h"
#include "service/tables/signatures.h"
#include "tasks/basic_task.h"
Expand Down Expand Up @@ -805,8 +807,37 @@ namespace ccf

std::vector<uint8_t> root_hash{
root.h.data(), root.h.data() + root.h.size()};
return cose_verifier_cached(service_info->cert)
->verify_detached(cose_sig.value(), root_hash);
if (!cose_verifier_cached(service_info->cert)
->verify_detached(cose_sig.value(), root_hash))
{
return false;
}

if (ccf::logger::config::ok(LoggerLevel::DEBUG))
{
try
{
auto receipt = ccf::cose::decode_ccf_receipt(
cose_sig.value(), /* recompute_root */ false);
if (receipt.phdr.cwt.iat.has_value())
{
LOG_DEBUG_FMT(
"Verified COSE signature for TxID {}, issued at {}",
receipt.phdr.ccf.txid,
ccf::ds::to_x509_time_string(
std::chrono::system_clock::from_time_t(
receipt.phdr.cwt.iat.value())));
}
}
catch (const std::exception& e)
{
LOG_DEBUG_FMT(
"Failed to decode COSE protected header for debug logging: {}",
e.what());
}
}

return true;
}

std::vector<uint8_t> serialise_tree(size_t to) override
Expand Down
Loading