Made close buttons bigger, LED icon buttons interactive.#868
Open
glastonbridge wants to merge 1 commit intoappsfrom
Open
Made close buttons bigger, LED icon buttons interactive.#868glastonbridge wants to merge 1 commit intoappsfrom
glastonbridge wants to merge 1 commit intoappsfrom
Conversation
|
Preview build will be at |
|
Mostly LGTM, there's a weird behaviour where it seems like the third tap doesn't do anything. First tap opens popover, second tap closes popover, third tap does nothing. icon-click.movAdding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a conservative amount of hidden hit area to help with clicking close buttons, tested on mobile and it makes a difference.
Also associate the LED Icon SVG with the LED Icon picker in the ActionNameCard so that it can be clicked as a single unit. This is significant on mobile where it is intuitive to tap the LED Icon to change it, but the dropdown icon still gives the affordance that it is something that can be changed.
Addresses #856 #560