Disconnect in pairing mode before downloading MakeCode project#852
Draft
microbit-grace wants to merge 1 commit intoappsfrom
Draft
Disconnect in pairing mode before downloading MakeCode project#852microbit-grace wants to merge 1 commit intoappsfrom
microbit-grace wants to merge 1 commit intoappsfrom
Conversation
|
Preview build will be at |
Author
|
Needs discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #845
Disconnecting when user is in pairing mode avoids the sad face from being shown on the micro:bit because the micro:bit is not in application mode. At the same time, it also avoids the connection lost dialog from popping up.
However, it would make encountering this issue more probable. Users may enter pairing mode on the micro:bit, decide to not download the program, return to the testing model page to see the graph lines missing.