Skip to content

Check that the store id is defined and redirect to home if undefined #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microbit-robert merged 2 commits into from
Apr 8, 2026
+3 −4
Merged

Check that the store id is defined and redirect to home if undefined #848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65dd6e9
Also check that the store id is defined and redirect to home if not
microbit-robert Apr 8, 2026
57eb03a
Use projectId once, remove pointless dep
microbit-robert Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/pages/DataSamplesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,15 @@ const DataSamplesPage = () => {
const actions = useStore((s) => s.actions);
const addNewAction = useStore((s) => s.addNewAction);
const model = useStore((s) => s.model);
const newSession = useStore((s) => s.newSession);
const projectId = useStore((s) => s.id);
const [selectedActionIdx, setSelectedActionIdx] = useState<number>(0);
const navigate = useNavigate();

useEffect(() => {
if (!projectSessionStorage.getProjectId()) {
if (!projectSessionStorage.getProjectId() || !projectId) {
return navigate(createHomePageUrl());
}
}, [navigate, newSession]);
}, [navigate, projectId]);

const trainModelFlowStart = useStore((s) => s.trainModelFlowStart);

Expand Down Expand Up @@ -94,7 +94,6 @@ const DataSamplesPage = () => {
const welcomeDialogDismissedForProject = useStore(
(s) => s.welcomeDialogDismissedForProject
);
const projectId = useStore((s) => s.id);
const dismissWelcomeDialog = useStore((s) => s.dismissWelcomeDialog);
const isWelcomeDialogOpen =
!isConnected && welcomeDialogDismissedForProject !== projectId;
Expand Down
Loading