Skip to content

Add cannot see pattern link to enter pattern dialog#843

Merged
microbit-grace merged 4 commits into
appsfrom
cannot-see-pattern
Apr 8, 2026
Merged

Add cannot see pattern link to enter pattern dialog#843
microbit-grace merged 4 commits into
appsfrom
cannot-see-pattern

Conversation

@microbit-grace
Copy link
Copy Markdown

@microbit-grace microbit-grace commented Apr 7, 2026

Fixes #844

Should only affect apps

Screenshot 2026-04-08 at 10 45 44

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

@microbit-grace microbit-grace requested a review from a team April 8, 2026 09:45
headingId={headingId}
footerLeft={
isNativePlatform() ? (
<Button onClick={handleBackClick} variant="link" size="lg">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size of the previous link text in the previous dialog is smaller (16px) and this one is 18px.

Copy link
Copy Markdown
Author

@microbit-grace microbit-grace Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! cafcee7

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The welcome dialog link should be the only inconsistent one at the moment. Will fix that one in this PR instead to reduce conflicts.

Copy link
Copy Markdown

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbit-grace microbit-grace merged commit c3dc922 into apps Apr 8, 2026
3 checks passed
@microbit-grace microbit-grace deleted the cannot-see-pattern branch April 8, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants