Skip to content

Don't allow Button B recording if dialog opened #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
microbit-grace merged 1 commit into from
Apr 2, 2026
Merged

Don't allow Button B recording if dialog opened #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/DataSamplesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ const DataSamplesTable = ({

const connection = useConnectActions();
const { isConnected } = useConnectionStage();
const isNonConnectionDialogOpen = useStore(
(s) => s.isNonConnectionDialogOpen
);

// For adding flashing animation for new recording.
const [newRecordingId, setNewRecordingId] = useState<string | undefined>(
Expand All @@ -90,12 +93,11 @@ const DataSamplesTable = ({

useEffect(() => {
const listener = (e: ButtonEvent) => {
// Allow Button B recording when tour is not in progress and the
// Allow Button B recording when no dialogs are opened and the
// record button for selected action is displayed.
if (
!isRecordingDialogOpen &&
!isNonConnectionDialogOpen() &&
e.state &&
tourState === undefined &&
(selectedAction.name.length > 0 || selectedAction.recordings.length > 0)
) {
setRecordingOptions({
Comment on lines +99 to 101
Copy link
Copy Markdown
Author

@microbit-grace microbit-grace Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tour state check is included in isNonConnectionDialogOpen (see here)

Expand All @@ -111,7 +113,7 @@ const DataSamplesTable = ({
};
}, [
connection,
isRecordingDialogOpen,
isNonConnectionDialogOpen,
recordingDialogOnOpen,
selectedAction,
tourState,
Expand Down
Loading