Add storage error handling to apps#831
Merged
Merged
Conversation
Write errors (quota exceeded, unexpected failures) show a persistent toast via store state observed in Layout, keeping the app usable. Read errors propagate to the React Router error boundary. First error per session is reported to Sentry; subsequent ones are suppressed. Includes e2e tests that monkey-patch IDBObjectStore to simulate both write and read failures.
|
Preview build will be at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've not tried to distinguish the two cases here.
For some reason "connect-or-import" was still on the apps branch. I've removed it here.
You can see the apps branch specific bits in b87aa3a