Update hints to handle edge cases and reduce move hint frequency#823
Merged
microbit-grace merged 16 commits intobetafrom Mar 31, 2026
Merged
Update hints to handle edge cases and reduce move hint frequency#823microbit-grace merged 16 commits intobetafrom
microbit-grace merged 16 commits intobetafrom
Conversation
|
Preview build will be at |
- Trigger new action-name-short hint for first unnamed action with no recordings - Trigger hint for first action with no recordings. Also, tweak positioning of record action hint
and temporarily remove skipping of first 10 samples.
- reconnecting - deleting action(s)/recording - being connected in testing model page - changing an action name
Author
|
Rebased on top of latest beta changes to check longer text length when in different languages. |
| dataSamplesHint.type === "move-microbit" && | ||
| settings.toursCompleted.includes("Connect") | ||
| ) { | ||
| setTimeout(() => setHasMoved(true), moveMicrobitHintTimeoutInSec * 1000); |
There was a problem hiding this comment.
The setTimeout is not cleaned up. If the effect re-runs (e.g., user disconnects/reconnects, dialog opens/closes), a new timeout is scheduled each time without cancelling the previous one. Probably no actual harm because it's store state but I still think this should return a cleanup function. Might be easier if the effect is split in two.
microbit-matt-hillsdon
requested changes
Mar 31, 2026
microbit-matt-hillsdon
left a comment
microbit-matt-hillsdon
left a comment
There was a problem hiding this comment.
One timeout tidy up but otherwise this looks good to me.
microbit-matt-hillsdon
approved these changes
Mar 31, 2026
microbit-matt-hillsdon
left a comment
microbit-matt-hillsdon
left a comment
There was a problem hiding this comment.
LGTM, thanks for working through these tweaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New edge cases considered:
Move hint visibility has been updated so that:
Fixes #803