Clear input after posting status — skip save/restore on submit refresh#570
Merged
Clear input after posting status — skip save/restore on submit refresh#570
Conversation
After posting, refresh(true) was saving currentInput() then restoring it into the new DOM, which put the old text back in the input even though it had been cleared. Now when scrollToTop is true (only after a submit), the save/restore is skipped — the fresh form from the server has an empty input as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After posting, refresh(true) was saving currentInput() then restoring it into the new DOM, which put the old text back in the input even though it had been cleared. Now when scrollToTop is true (only after a submit), the save/restore is skipped — the fresh form from the server has an empty input as expected.