Repository navigation
fix(model): propagate in-stream provider errors - #5066
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model.Stream()currently drops OpenAI-compatible SSEerrorobjects. An error before any content becomes a normal EOF; an error after partial text can become a successful response withStopReason: "error". Callers can therefore mistake a failed, incomplete reply for normal completion.Return the provider error message from all three OpenAI-compatible readers: the shared reader, OpenAI, and Atlas Cloud. This matches the existing incremental
Generate()error handling. The protocol case is documented under OpenRouter streaming errors.Verification
bc4185band pass with this change.go test -race ./model/...passed.go build ./...passed.golangci-lint run ./...passed (v2.14.0, matching CI).TERM=dumb go test -timeout 120s ./...passed: 106 packages; the existing suite skips 36 test nodes. Go 1.26.10 was used.With an unset
TERM, fourTestStreamedReferenceLinkssubtests fail because their URL substring counts include OSC 8 hyperlink escape sequences. They fail identically on unchangedbc4185b. The supported plain-terminal mode (TERM=dumb) strips those escapes and passes the full suite. This PR does not edit the renderer or its tests.The new regression cases use
httptestfixtures. No authenticated live-model inference was validated.AI assistance
Prepared, tested, and self-reviewed with OpenAI Codex (GPT-6, autonomous) for @shuaiyafei. Maintainer edits are enabled.