Skip to content

fix(etcd): backport nil PrevKv handling to v5 - #5041

Merged
asim merged 1 commit into
v5from
codex/5040-v5-etcd-watcher-fix
Oct 27, 2026
Merged

asim merged 1 commit into
v5from
codex/5040-v5-etcd-watcher-fix

Conversation

@asim

@asim asim commented Oct 27, 2026

Copy link
Copy Markdown
Member

Summary

Testing

  • go test ./registry/etcd
  • go build ./...
  • git diff --check v5.30.0...HEAD
  • go test ./... (environment blocks loopback connections in unrelated gRPC tests)
  • golangci-lint run ./... (installed linter cannot read this branch's legacy configuration)

Backports #5040.
Closes #1481.

Co-authored-by: Codex <codex@openai.com>
@asim asim added the codex label Oct 27, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T10:59:35.186431Z b749e28 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@asim
asim merged commit 3724972 into v5 Oct 27, 2026
6 of 8 checks passed
@asim
asim deleted the codex/5040-v5-etcd-watcher-fix branch October 27, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant