Repository navigation
harness/new: honest conformance timeout + cheaper contract test (re-land of #3007) - #3008
Merged
Merged
Conversation
Follow-up to #3006: - provider-conformance: build each harness to a temp binary and run that instead of 'go run'. 'go run' launches the harness as a child it doesn't kill on context cancellation, so a timed-out harness (which starts local services) could be orphaned and outlive the run. Running the built binary makes the per-run timeout actually terminate the work. - contract test: skip under -short, and use 'go build ./...' instead of 'go test ./...' (the contract is that the generated service builds). This keeps the default unit-test suite from shelling out to the toolchain and the network on every run. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CmdEY7pYmV5zzwCjNJ4ykL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the mechanical fixes from #3007 against master. The original #3007 was based on the (now-merged) codex branch, so when that branch merged as #3006, #3007's diff didn't reach master — these never actually landed. Same two changes, verified against current master:
internal/harness/provider-conformance— build each harness to a temp binary and exec that instead ofgo run.go runlaunches the harness as a child it doesn't kill on context cancellation, so a timed-out harness (which starts local services) could be orphaned. Building + exec'ing makes the per-run timeout actually terminate the work.cmd/micro/cli/new/contract_test.go— skip under-short(so the default unit suite doesn't shell out togo mod tidy+ compile a generated service on every run), and usego build ./...instead ofgo test ./...(the contract is that it builds).Verified on master:
go build ./...,golangci-lint run(0 issues),go test -short ./cmd/micro/cli/new/skips fast.🤖 Generated with Claude Code
Generated by Claude Code