Skip to content

harness/new: honest conformance timeout + cheaper contract test (re-land of #3007) - #3008

Merged
asim merged 1 commit into
masterfrom
claude/loving-meitner-3Etoi
Jun 24, 2026
Merged

asim merged 1 commit into
masterfrom
claude/loving-meitner-3Etoi

Conversation

@asim

@asim asim commented Jun 24, 2026

Copy link
Copy Markdown
Member

Re-lands the mechanical fixes from #3007 against master. The original #3007 was based on the (now-merged) codex branch, so when that branch merged as #3006, #3007's diff didn't reach master — these never actually landed. Same two changes, verified against current master:

internal/harness/provider-conformance — build each harness to a temp binary and exec that instead of go run. go run launches the harness as a child it doesn't kill on context cancellation, so a timed-out harness (which starts local services) could be orphaned. Building + exec'ing makes the per-run timeout actually terminate the work.

cmd/micro/cli/new/contract_test.go — skip under -short (so the default unit suite doesn't shell out to go mod tidy + compile a generated service on every run), and use go build ./... instead of go test ./... (the contract is that it builds).

Verified on master: go build ./..., golangci-lint run (0 issues), go test -short ./cmd/micro/cli/new/ skips fast.

🤖 Generated with Claude Code


Generated by Claude Code

Follow-up to #3006:

- provider-conformance: build each harness to a temp binary and run that
  instead of 'go run'. 'go run' launches the harness as a child it doesn't
  kill on context cancellation, so a timed-out harness (which starts local
  services) could be orphaned and outlive the run. Running the built binary
  makes the per-run timeout actually terminate the work.
- contract test: skip under -short, and use 'go build ./...' instead of
  'go test ./...' (the contract is that the generated service builds). This
  keeps the default unit-test suite from shelling out to the toolchain and
  the network on every run.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CmdEY7pYmV5zzwCjNJ4ykL
@asim
asim merged commit daacd48 into master Jun 24, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants