Add Data Matrix Rectangular Extension (DMRE) support as encoding option#631
Open
cs-ruman wants to merge 2 commits into
Open
Add Data Matrix Rectangular Extension (DMRE) support as encoding option#631cs-ruman wants to merge 2 commits into
cs-ruman wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Data Matrix Rectangular Extension (DMRE) symbol selection available as an explicit opt-in encoding option.
It is related to PR #597. That PR added DMRE symbols, but the follow-up commit 4d3e585 disabled DMRE selection because it affected existing non-DMRE encoding behavior.
This PR keeps the existing default behavior unchanged:
EncodeHintType.DATA_MATRIX_DMREis explicitly enabled.SymbolShapeHintkeeps its existing meaning. Enabling DMRE does not force rectangular output; it only allows DMRE symbols to be selected when they otherwise match the symbol constraints.The new option is exposed through
DatamatrixEncodingOptions.EnableDMREand passed through the encoder path down toSymbolInfo.lookup.Added tests cover: