Skip to content

Fixes sign bug in max-based normalization #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarmey merged 1 commit into from
Jun 12, 2026
Merged

Fixes sign bug in max-based normalization #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorpack/coupled.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def normalize_factors(self, method="max"):
for mmode in self.modes:
sol = self.x["_" + mmode]
if method == "max": # the one with maximum absolute value
norm_vec = np.array([max(sol[:, ii].min(), sol[:, ii].max(), key=abs) for ii in range(sol.shape[1])])
norm_vec = abs(sol).max(axis=0).to_numpy()
elif method == "norm":
norm_vec = norm(sol, axis=0)
else:
Expand Down
Loading