Repository navigation
Keep the development tooling out of the library repository - #39
Merged
Merged
Conversation
The per-developer tooling added earlier today does not belong in a published library: it is specific to how one person works, it is useless to anyone who clones this, and it put a dozen configuration files and two CI jobs in front of readers looking for the library. It now lives in a private repository and is linked into each checkout locally, through .git/info/exclude, so it never reaches this history. Contributors who do not use it see nothing and need nothing. The audit scripts stay, because they are not tooling: they re-derive the numbers quoted in the library's own comments, and this project's rule is that a reported number is reproducible from a committed script. They move to evidence/, together with the atmospheric-correction expert survey, which is written to be read by outside reviewers. Nine comments in src/ and tests/ cited the old paths. Those pointing at an audit directory now point at evidence/; those pointing at a planning document name the work instead of a path this repository no longer holds. ci.yml's path filter follows the rename. 592 passed / 18 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-developer tooling added earlier today does not belong in a published library. It is specific to how one person works, it is useless to anyone who clones this, and it put a dozen configuration files and two CI jobs in front of readers looking for the library.
It now lives in a private repository and is linked into each checkout locally, through
.git/info/exclude, so it never reaches this history. Contributors who do not use it see nothing and need nothing.What stays, and why
The audit scripts are not tooling, so they stay — moved from the old directory to
evidence/:evidence/atmospheric_correction_audit/evidence/s5p_s3_audit/evidence/bulk_processing_audit/evidence/composites_audit/evidence/s3_review_audit/evidence/atmospheric_correction_expert_survey.mdThey re-derive the numbers quoted in the library's own comments, and this project's rule is that a reported number is reproducible from a committed script. Keeping them private would have made it reproducible only in private.
References
Nine comments in
src/andtests/cited the old paths. Those pointing at an audit directory now point atevidence/; those pointing at a planning document name the work instead of a path this repository no longer holds.ci.yml's path filter follows the rename, and one redundant.gitignoreline goes with it.Verification