-
Notifications
You must be signed in to change notification settings - Fork 2
Add compatibility for metal-console API V2. #722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Gerrit91
wants to merge
8
commits into
master
Choose a base branch
from
metal-console-dual-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b0fe1c1
Add compatibility for metal-console API V2.
Gerrit91 c8d2ed1
Syntaktisch fragwürdig
Gerrit91 61e3003
Meta
Gerrit91 6006fb2
Renaming.
Gerrit91 ce363b6
Linti linti
Gerrit91 b60c4a0
Merge branch 'master' of https://github.com/metal-stack/metal-roles i…
majst01 244e0ac
Reduce required permissions
majst01 dfae753
Fix
majst01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| - name: Create api token for metal-console | ||
| delegate_to: localhost | ||
| environment: | ||
| METAL_APIV2_URL: "{{ metal_apiserver_url }}" | ||
| METAL_APIV2_TOKEN: "{{ hostvars['localhost'].metal_deployment_admin_token }}" | ||
| block: | ||
| - name: Create metal-console tenant | ||
| metal_v2_admin_tenant: | ||
| identifier: metal-console | ||
| name: metal-console | ||
| description: tenant used by the metal-console | ||
| register: _tenant | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please check back with #453 where I made some important additions (run_once here and use-latest-identifier for the token module). |
||
|
|
||
| - name: Create metal-console api token | ||
| metal_v2_admin_token: | ||
| identifier: metal-console | ||
| user: "{{ _tenant.id }}" | ||
| description: metal-console token | ||
| expires: "{{ metal_console_token_expiration }}" | ||
| permissions: "{{ metal_console_token_permissions }}" | ||
| register: _token | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cross-usage of variable. In #453, I added a shared partition variable for this. Please use them and create a default for this role with a fallback to the partition default.