Skip to content

Use boolean jinja2 template overrides #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GeertJohan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use boolean jinja2 template overrides #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion partition/roles/dhcp/templates/dhcpd.hosts.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#jinja2: lstrip_blocks: "True", trim_blocks: "True"
#jinja2: lstrip_blocks: True, trim_blocks: True
{% for host in dhcp_static_hosts %}
host {{ host.name }} {
hardware ethernet {{ host.mac }};
Expand Down
2 changes: 1 addition & 1 deletion partition/roles/sonic-config/templates/frr.conf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#jinja2: lstrip_blocks: "True", trim_blocks: "True"
#jinja2: lstrip_blocks: True, trim_blocks: True
frr defaults datacenter
hostname {{ inventory_hostname }}
!
Expand Down
2 changes: 1 addition & 1 deletion partition/roles/sonic/templates/frr.conf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#jinja2: lstrip_blocks: "True", trim_blocks: "True"
#jinja2: lstrip_blocks: True, trim_blocks: True
frr defaults datacenter
hostname {{ inventory_hostname }}
!
Expand Down
2 changes: 1 addition & 1 deletion partition/roles/sonic/templates/metal.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#jinja2: lstrip_blocks: "False", trim_blocks: "False"
#jinja2: lstrip_blocks: True, trim_blocks: True

@GeertJohan GeertJohan Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this change keeps behavior unchanged, but perhaps we want to change the behavior to actually lstrip and trim?

---
{% set vrfs = [] %}
DEVICE_METADATA:
Expand Down
Loading