Sflow integration - #584
Open
Sven-Ric wants to merge 37 commits into
Open
Conversation
This was referenced May 4, 2026
Sven-Ric
force-pushed
the
sflow-integration
branch
from
July 2, 2026 21:55
f6c3f27 to
fb2a25b
Compare
Currently vector is not using updated CSVs
The role has matured beyond the scope of the sflow integration and now lives on the lldp-weathermap branch.
Sven-Ric
force-pushed
the
sflow-integration
branch
from
July 10, 2026 07:52
f1c4964 to
a7bcdd9
Compare
iljarotar
reviewed
Jul 13, 2026
iljarotar
left a comment
iljarotar
left a comment
Contributor
There was a problem hiding this comment.
Looks good, mostly. The sflow-collector role is missing a README.
Have you tried all of this on both, Broadcom and Edgecore SONiC? What interface does goflow2 use? If it's gNMI, I'm not sure it will work with Edgecore.
| | partition_prometheus_rules_node_exporter | | node-exporter alert rules | | ||
| | partition_prometheus_rules_pixiecore | | pixiecore alert rules | | ||
| | partition_prometheus_rules_sonic_exporter | | sonic-exporter alert rules | | ||
| | partition_prometheus_rules_goflow2 | | goflow2 sFlow collector rules | |
Contributor
There was a problem hiding this comment.
partition_prometheus_rules_sonic_systemd is missing.
| monitoring_node_exporter_port: 9100 | ||
| monitoring_node_exporter_dir: /node_exporter | ||
| monitoring_node_exporter_docker_log_driver: json-file | ||
| monitoring_node_exporter_systemd_unit: "(bgp|swss)\\.service" |
Contributor
There was a problem hiding this comment.
Is this variable documented?
| prometheus_ipmi_exporter_targets: [] | ||
| prometheus_sonic_exporter_targets: [] | ||
| prometheus_blackbox_exporter_targets: [] | ||
| prometheus_goflow2_targets: [] |
Contributor
There was a problem hiding this comment.
Is this variable documented?
Comment on lines
+2
to
+5
| # Downloads a DP-IP Database and replaces the existing one. | ||
| # DB-IP updates monthly, so the current month is attempted first | ||
| # If the DB for the current month is not available yet, the scripts | ||
| # falls back to last month. |
Contributor
There was a problem hiding this comment.
Is it DP-IP or DB-IP?
And another nit 🙈: it should be the script not the scripts
Co-authored-by: Ilja Rotar <77339620+iljarotar@users.noreply.github.com>
Co-authored-by: Ilja Rotar <77339620+iljarotar@users.noreply.github.com>
ma-hartma
reviewed
Jul 13, 2026
Contributor
There was a problem hiding this comment.
This file will be removed soon, as the promtail role was deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #549.
This branch implements sflow based flow monitoring.
Used AI-Tools ✨
claude was used for weathermap visualisation