Skip to content

Ensure image.url is unique per os - #70

Draft
majst01 wants to merge 3 commits into
mainfrom
ensure-distict-image-url-per-os
Draft

Ensure image.url is unique per os#70
majst01 wants to merge 3 commits into
mainfrom
ensure-distict-image-url-per-os

Conversation

@majst01

@majst01 majst01 commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Description

Related to: #237

Depends on:

@majst01
majst01 requested a review from a team as a code owner September 10, 2025 05:47
@metal-robot metal-robot Bot added the area: control-plane Affects the metal-stack control-plane area. label Sep 10, 2025
@majst01 majst01 self-assigned this Sep 10, 2025
@codecov

codecov Bot commented Sep 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.91398% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.80%. Comparing base (3980e4c) to head (e707187).
⚠️ Report is 68 commits behind head on main.

Files with missing lines Patch % Lines
pkg/repository/image-validation.go 53.40% 28 Missing and 13 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      metal-stack/metal-api#70      +/-   ##
==========================================
+ Coverage   64.68%   64.80%   +0.11%     
==========================================
  Files          98       99       +1     
  Lines       10539    10566      +27     
==========================================
+ Hits         6817     6847      +30     
+ Misses       3070     3068       -2     
+ Partials      652      651       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@majst01
majst01 force-pushed the ensure-distict-image-url-per-os branch from 4da731a to 104ee39 Compare September 10, 2025 06:05
@majst01 majst01 changed the title Ensure image.url is distinct per os Ensure image.url is unique per os Sep 10, 2025
@majst01
majst01 force-pushed the ensure-distict-image-url-per-os branch from 104ee39 to eb6efde Compare September 10, 2025 06:22
@majst01

majst01 commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

We decided to ensure unique url over all images

@majst01
majst01 marked this pull request as draft September 11, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: control-plane Affects the metal-stack control-plane area.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant