Skip to content

External network members endpoints - #302

Open
iljarotar wants to merge 16 commits into
mainfrom
external-network-members-endpoints
Open

External network members endpoints#302
iljarotar wants to merge 16 commits into
mainfrom
external-network-members-endpoints

Conversation

@iljarotar

@iljarotar iljarotar commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Implements endpoints for external network members. An external member is a host that is connected to one of our racks but is not itself registered at the api.

depends on metal-stack/api#188

TODO

  • validate network type
  • validate only unmanaged ports can be added as external members
  • validate machine register is only allowed for internal or unmanaged ports
  • when a machine registers at an unmanaged port it must be set to internal
  • when a machine gets deleted from the database the port must be set to unmanaged

@metal-robot metal-robot Bot added the area: control-plane Affects the metal-stack control-plane area. label Sep 2, 2026
@metal-robot metal-robot Bot added this to Development Sep 2, 2026
@iljarotar
iljarotar marked this pull request as ready for review September 2, 2026 09:35
@iljarotar
iljarotar requested a review from a team as a code owner September 2, 2026 09:35
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.64583% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.97%. Comparing base (bb7c6ce) to head (b17e252).

Files with missing lines Patch % Lines
pkg/test/scenarios/spec.go 64.28% 15 Missing ⚠️
pkg/db/generic/initialize.go 7.69% 12 Missing ⚠️
pkg/repository/network.go 92.00% 8 Missing ⚠️
pkg/test/datacenter.go 82.60% 4 Missing ⚠️
cmd/server/datastore-cmd.go 0.00% 1 Missing ⚠️
pkg/service/admin/network/network-service.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   79.93%   79.97%   +0.04%     
==========================================
  Files         199      200       +1     
  Lines       14800    14941     +141     
==========================================
+ Hits        11830    11949     +119     
- Misses       2969     2991      +22     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/db/generic/integer_pool.go Outdated
Comment thread go.mod Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: control-plane Affects the metal-stack control-plane area.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants