Skip to content

Handle A and AAAA records TTL properly in dnscache - #187

Merged
iljarotar merged 75 commits into
masterfrom
186-dns-based-cwnps-not-reliable-on-hostnames-with-constantly-changing-ips
Sep 12, 2025
Merged

Handle A and AAAA records TTL properly in dnscache#187
iljarotar merged 75 commits into
masterfrom
186-dns-based-cwnps-not-reliable-on-hostnames-with-constantly-changing-ips

Conversation

@mreiger

@mreiger mreiger commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@mreiger mreiger linked an issue Aug 29, 2024 that may be closed by this pull request
DNS-based CWNPs not reliable on hostnames with constantly changing IPs #186
Closed
mreiger and others added 28 commits August 29, 2024 12:06
@mreiger
Fix linter errors
478a990
@mreiger
Fix remaining linter error
bafef1a
@mreiger
Forgot to initialize map
2d8f679
@mreiger
Another uninitialized map
8df351c
@mreiger
Fix nftables generation: Only add IP port of RR to cache
c05d4f1
@mreiger
Try to fix expiration date
42d089e
@mreiger
Second attempt to fix expiration time
7b87dc0
@mreiger
Try keep the CRD stable
a814da6
@mreiger
Add forgotten error handling
4c406fd
@mreiger
Try and fix bug where only one rule's FQDNState would be shown
dddc7af
@mreiger
Fix forgotten initialisation of map
c67aa1c
@majst01
Merge master
49f25e5
@mreiger
get shoot client to dns cache for handling state configmap
53ecc4b
@mreiger
Merge branch 'master' of github.com:metal-stack/firewall-controller i…
15578a5 
…nto 186-dns-based-cwnps-not-reliable-on-hostnames-with-constantly-changing-ips
@mreiger
Implement writing to state configmap
fabc726
@mreiger
pacify linter
8215f60
@mreiger
update setup-gcloud
559f37d
@mreiger
Try and initialize the configmap correctly
9b36afb
@mreiger
Try different approach for initialising dns cache from configmap
ea9bfb2
@mreiger
properly check for existing configmap
2064bfa
@mreiger
Actually try to write dns cache to configmap
e14c8de
@mreiger
Do not try to write nil cache to configmap; debug output
e65d682
@mreiger
Try and turn on debug logging
febbaf6
@mreiger
remove accidental package definition
6069a05
@mreiger
Try to fix JSON marshaling
70ac71c
@mreiger
Export fields so the json library can read them
bffdffb
@mreiger
Try to fix configmap creation
9f16a98
@mreiger
Avoid writing to nil map
c9ebc62
iljarotar
iljarotar reviewed Aug 21, 2025
View reviewed changes
Comment thread pkg/dns/dnscache.go
iljarotar
iljarotar reviewed Aug 21, 2025
View reviewed changes
Comment thread pkg/dns/dnscache.go
iljarotar
iljarotar reviewed Aug 21, 2025
View reviewed changes
Comment thread pkg/dns/dnscache.go Outdated
iljarotar
iljarotar reviewed Aug 21, 2025
View reviewed changes
Comment thread pkg/nftables/networkpolicy_test.go
iljarotar
iljarotar reviewed Aug 21, 2025
View reviewed changes
Comment thread pkg/dns/dnscache.go Outdated
@Gerrit91 Gerrit91 added the minor Breaking change or new feature, causes the release drafter to create a new minor version label Sep 4, 2025
Gerrit91
Gerrit91 reviewed Sep 4, 2025
View reviewed changes

@Gerrit91 Gerrit91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another set of comments, I hope they are useful.

Comment thread api/v1/clusterwidenetworkpolicy_types.go Outdated
Comment thread main.go Outdated
Comment thread pkg/dns/dnscache.go Outdated
Comment thread pkg/dns/dnscache.go Outdated
Comment thread pkg/dns/dnscache.go
Comment thread pkg/dns/dnscache.go
Comment thread pkg/dns/dnscache.go Outdated
Comment thread pkg/dns/dnscache.go Outdated
Comment thread pkg/nftables/util.go
Comment thread pkg/dns/dnscache.go Outdated
@iljarotar
iljarotar requested a review from Gerrit91 September 5, 2025 09:10
Gerrit91
Gerrit91 reviewed Sep 12, 2025
View reviewed changes
Comment thread pkg/dns/dnscache.go Outdated
@iljarotar
iljarotar merged commit 9efcb2e into master Sep 12, 2025
2 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Development Sep 12, 2025
@iljarotar
iljarotar deleted the 186-dns-based-cwnps-not-reliable-on-hostnames-with-constantly-changing-ips branch September 12, 2025 14:34
@Gerrit91 Gerrit91 mentioned this pull request Jan 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majst01 majst01 majst01 left review comments
@iljarotar iljarotar iljarotar left review comments
@Gerrit91 Gerrit91 Gerrit91 approved these changes

Assignees

@Gerrit91 Gerrit91

Labels

minor Breaking change or new feature, causes the release drafter to create a new minor version

Projects

Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DNS-based CWNPs not reliable on hostnames with constantly changing IPs

6 participants

@mreiger @majst01 @Gerrit91 @iljarotar @vknabel @simcod