Run tests on Auto docs updates - #1305
Merged
Merged
Conversation
iethree
marked this pull request as draft
August 26, 2026 22:05
iethree
marked this pull request as ready for review
August 28, 2026 21:00
bpander
approved these changes
Aug 31, 2026
| echo "htmlproofer took: ${SECONDS} seconds." | ||
| echo 'checking reported links...' | ||
| echo "htmlproofer spit out a report of length: $(wc -l < htmlproofer.out)" | ||
| bb script/analyze_links.clj --htmlproofer-output htmlproofer.out --limit 1 |
Contributor
There was a problem hiding this comment.
FWICT nothing calls this analyze_links.clj script anymore (it's different from lint-links). Was that intentionally removed?
Contributor
Author
There was a problem hiding this comment.
now that we are waiting for checks to pass on PRs, testing should be done in the test workflow. If that' still a necessary check, let's add it to that workflow and keep separate the concerns of 1) generate update PR and 2) test update PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
successful pr: #1313
successful run: https://github.com/metabase/docs.metabase.github.io/actions/runs/33209645338/job/98979456486?pr=1305