Skip to content

Add Elecrow ThinkNode M8 to the device hardware registry#107

Merged
thebentern merged 2 commits into
masterfrom
device-registry/thinknode-m8
Jul 26, 2026
Merged

Add Elecrow ThinkNode M8 to the device hardware registry#107
thebentern merged 2 commits into
masterfrom
device-registry/thinknode-m8

Conversation

@caveman99

@caveman99 caveman99 commented Jul 26, 2026

Copy link
Copy Markdown
Member

Adds the Elecrow ThinkNode M8 to deviceHardwareList, keyed by THINKNODE_M8 = 130.

  {
    hwModel: 130,
    hwModelSlug: "THINKNODE_M8",
    platformioTarget: "thinknode_m8",
    architecture: "nrf52840",
    activelySupported: false,
    supportLevel: 1,
    displayName: "Elecrow ThinkNode M8",
    tags: ["Elecrow"],
    images: ["thinknode-m8.svg"],
  },

Review checklist:

  • platformioTarget matches the firmware env (thinknode_m8)
  • flip activelySupported / supportLevel when the web flasher should list it
  • confirm images: ["thinknode-m8.svg"] is live in meshtastic/web-flasher (merge the device-image PR first)
  • requiresDfu / partitionScheme if the platform needs them

Entry generated from the live mesh.proto and registry at generation time.

Summary by CodeRabbit

  • New Features
    • Added support for the THINKNODE M8 hardware device.
    • Included device details such as platform compatibility, architecture, support status, display name, tags, and images.

Register the Elecrow ThinkNode M8 (HW_MODEL THINKNODE_M8 = 130).
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a38207a9-eda4-4c7c-a511-c653772b8a21

📥 Commits

Reviewing files that changed from the base of the PR and between 432af53 and 32ba42f.

📒 Files selected for processing (1)
  • src/lib/resource.ts

📝 Walkthrough

Walkthrough

The device hardware registry adds support metadata for THINKNODE_M8 (hwModel: 130) and adds a trailing comma to an existing image field.

Changes

Hardware registry

Layer / File(s) Summary
Register THINKNODE_M8 hardware
src/lib/resource.ts
Adds the THINKNODE_M8 hardware entry with platform, architecture, support, display, tag, and image metadata; also formats the adjacent HELTEC_MESH_NODE_T1 entry with a trailing comma.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested reviewers: thebentern, rcarteraz

Poem

I’m a rabbit who hops through the list,
A new THINKNODE joins the mist.
With tags and images neatly in view,
Hardware metadata grows anew.
A trailing comma gives a wink—
Then off I hop before you blink!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding the Elecrow ThinkNode M8 to the device hardware registry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thebentern

Copy link
Copy Markdown
Contributor

@copilot format the file

Copilot AI commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

@copilot format the file

Done — ran Biome formatter on the file (added trailing comma after "heltec-meshnode-t1.svg" that was flagged). Committed in style: format resource.ts with Biome.

Copilot AI requested a review from thebentern July 26, 2026 12:36
@thebentern
thebentern merged commit 6b19961 into master Jul 26, 2026
4 checks passed
@thebentern
thebentern deleted the device-registry/thinknode-m8 branch July 26, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants