fix(er): support left-side numeric entity identifier 1#7598
fix(er): support left-side numeric entity identifier 1#7598Gaston202 wants to merge 2 commits intomermaid-js:developfrom
Conversation
Disambiguate numeric token handling in ER parser so left-side entity name '1' works in relationship statements, while preserving right-side numeric entity cases from mermaid-js#7472.\n\n- refine lexer lookahead for cardinality token 1\n- allow ONLY_ONE token where an entity name is valid\n- add regression tests for left-side forms: '1 1 to many' and '1 many to many'\n\nRefs mermaid-js#7472
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7598 +/- ##
=======================================
Coverage 3.33% 3.33%
=======================================
Files 536 536
Lines 56249 56249
Branches 820 820
=======================================
Hits 1876 1876
Misses 54373 54373
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Disambiguate numeric token handling in ER parser so left-side entity name "1" works in relationship statements, while preserving right-side numeric entity cases from #7472.
Refs #7472
📑 Summary
This PR fixes an ER parser regression where the left-side entity name "1" could be interpreted as cardinality in relationship statements.
It disambiguates numeric token handling so left-side numeric entity names parse correctly, while preserving the right-side numeric entity behavior introduced in #7472.
Resolves #7472
📏 Design Decisions
📋 Tasks
Make sure you