Skip to content

feat(#383): Improvements to "Building App Forms" page - #1986

Merged
mrjones-plip merged 6 commits into
medic:mainfrom
jomcarvajal:383-improvements-to-Building_App_Forms-page
Sep 26, 2025
Merged

mrjones-plip merged 6 commits into
medic:mainfrom
jomcarvajal:383-improvements-to-Building_App_Forms-page

Conversation

@jomcarvajal

@jomcarvajal jomcarvajal commented Sep 11, 2025 •

Copy link
Copy Markdown
Contributor

Description

Closes #383

Modifications:

The styles tried to mimic the page style. If the color, margin, background or anything else don't fit then let me know what options could be better.

Screenshots:

Screenshot 2025-09-10 at 7 41 34 PM Screenshot 2025-09-10 at 7 41 40 PM Screenshot 2025-09-10 at 7 41 57 PM Screenshot 2025-09-10 at 7 42 06 PM

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@jomcarvajal
jomcarvajal marked this pull request as ready for review September 11, 2025 12:24
@mrjones-plip
mrjones-plip self-requested a review September 26, 2025 00:14

@mrjones-plip mrjones-plip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks so much @jomcarvajal - this is really great feature and it just works to quickly copy content to either Google Sheets or LibreOffice.

I've made some inline suggestions that are pretty minor.

As well, could you add a note to the Style Guide on how to use this new table feature? This way folks in the future will have an easier time of seeing how to use it. I suggest looking at tabular schedules as an example

Comment thread content/en/building/tutorials/app-forms.md Outdated
Comment thread layouts/shortcodes/copytable.html

@mrjones-plip mrjones-plip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - thank your for making them.

I can't compile the site locally and CI is failing the same error I see:

 Error: error building site: process: readAndProcessContent: "/home/runner/work/cht-docs/cht-docs/content/en/building/tutorials/app-forms.md:52:1": failed to extract shortcode: template for shortcode "copytable" not found

I think you maybe renamed some variable and forgot to commit it or something?

Once we fix this I think we'll be good to go!

@jomcarvajal

Copy link
Copy Markdown
Contributor Author

Changes look good - thank your for making them.

I can't compile the site locally and CI is failing the same error I see:

 Error: error building site: process: readAndProcessContent: "/home/runner/work/cht-docs/cht-docs/content/en/building/tutorials/app-forms.md:52:1": failed to extract shortcode: template for shortcode "copytable" not found

I think you maybe renamed some variable and forgot to commit it or something?

Once we fix this I think we'll be good to go!

Should be working now 👍

@mrjones-plip mrjones-plip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go - thanks so much for the speedy replies!

Made some minor suggestions to normalize the headings, not blocking though, so approved and up to you

Image

Comment thread content/en/community/contributing/docs/style-guide.md Outdated
Comment thread content/en/community/contributing/docs/style-guide.md Outdated
Comment thread content/en/community/contributing/docs/style-guide.md Outdated
@mrjones-plip
mrjones-plip merged commit bc18ce4 into medic:main Sep 26, 2025
1 check passed
@mrjones-plip

mrjones-plip commented Sep 26, 2025 •

Copy link
Copy Markdown
Contributor

Thanks again @jomcarvajal ! This has been merged to main and should be live on the site in ~5min after CI does it's thing. So great to see this feature get out to the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvements to "Building App Forms" page

2 participants