Skip to content

chore(na): add k3s-k3d ingress template condition - #10405

Merged
mrjones-plip merged 2 commits into
masterfrom
fix-k3s-ingress-template-condition
Oct 23, 2025
Merged

mrjones-plip merged 2 commits into
masterfrom
fix-k3s-ingress-template-condition

Conversation

@lorerod

@lorerod lorerod commented Oct 23, 2025 •

Copy link
Copy Markdown
Contributor

Description

Adds conditional logic for the k3s-k3d platform ingress so that it does not override other cluster types.

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design. Test it has appropriate design for RTL languages.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@lorerod
lorerod requested a review from mrjones-plip October 23, 2025 19:28
@lorerod lorerod changed the title Add k3s-k3d ingress template condition add k3s-k3d ingress template condition Oct 23, 2025
@mrjones-plip

Copy link
Copy Markdown
Contributor

Note that this was related to the testing done on the docs eks CHT 4x -> 5x migration ticket.

@mrjones-plip mrjones-plip left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@mrjones-plip mrjones-plip changed the title add k3s-k3d ingress template condition chore(na): add k3s-k3d ingress template condition Oct 23, 2025
@mrjones-plip

mrjones-plip commented Oct 23, 2025 •

Copy link
Copy Markdown
Contributor

merging this even though CI is not passing because of this:

It is safe to ignore this failure for now and continue to merge PRs regardless (the failure does not block the merge button on the PR). The job should start passing again as soon as we drop 5.0.0.

@mrjones-plip
mrjones-plip merged commit f81492a into master Oct 23, 2025
149 of 163 checks passed
@mrjones-plip
mrjones-plip deleted the fix-k3s-ingress-template-condition branch October 23, 2025 23:31
@mrjones-plip mrjones-plip added this to the 5.0.0 milestone Oct 31, 2025
jonathanbataire pushed a commit to jonathanbataire/cht-core that referenced this pull request Dec 4, 2025
Co-authored-by: mrjones <8253488+mrjones-plip@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants