Skip to content

fix: make .editorconfig actually match the Makefile #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sugat009 merged 1 commit into from
Sep 27, 2026
Merged

fix: make .editorconfig actually match the Makefile #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ insert_final_newline = true
indent_style = space
indent_size = 2

[{*.java, Makefile}]
[{*.java,Makefile}]
indent_style = tab
indent_size = 4
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ Trailing PR numbers (`(#427)`) are appended automatically by the squash merge
## Conventions

- Java only. No Kotlin sources. Keep it that way unless the team decides otherwise.
- Tabs (size 4) for Java sources and the Makefile; 2-space indentation everywhere else (see `.editorconfig`). Caveat: the glob is `[{*.java, Makefile}]` — the stray space means `Makefile` does not actually match, so an editor honouring `.editorconfig` will indent it with spaces and break `make`. Keep Makefile recipe lines tab-indented regardless.
- Tabs (size 4) for Java sources and the Makefile; 2-space indentation everywhere else (see `.editorconfig`).
- Static imports for `MedicLog.{trace,log,warn,error}` and the helper utilities — match the existing style.
- Logging goes through `MedicLog`; `trace` is debug-only, `log/warn/error` are unconditional.
- Redact URLs that may contain credentials with `SimpleJsonClient2.redactUrl(...)` before logging.
Expand Down
Loading