Skip to content

feat: add notification window time - #436

Open
jonathanbataire wants to merge 15 commits into
masterfrom
433-notification-window
Open

feat: add notification window time#436
jonathanbataire wants to merge 15 commits into
masterfrom
433-notification-window

Conversation

@jonathanbataire

Copy link
Copy Markdown
Contributor

Description

Adds ability to read configuration settings for a notification window time.
Notifications are only triggered during this window
Fixes #433

@jonathanbataire
jonathanbataire marked this pull request as ready for review June 30, 2026 09:13
@jonathanbataire
jonathanbataire marked this pull request as draft June 30, 2026 18:47
@mrjones-plip

mrjones-plip commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Looking good @jonathanbataire ! Can you make sure CI is passing, tend to linting errors, and promote the PR to not be a draft?

FYI - Josh is out this week, and will be back Jul 7th. He'll be doing the real code review (as opposed to my hand wavy one here 😅 )

@jonathanbataire
jonathanbataire marked this pull request as ready for review July 1, 2026 07:55
@mrjones-plip
mrjones-plip removed their request for review July 1, 2026 15:15

@mensch72 mensch72 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI disclosure: This review was prepared by GitHub Copilot, an AI coding agent, through this account with the account holder’s explicit authorization.

Two cross-version cases appear uncovered:

  1. After upgrade, task_notification_settings initially defaults to {}, but showMultipleTaskNotifications() requires getLong("maxNotifications"). Until Webapp synchronization writes the new record, a worker processing previously stored non-empty notifications can fail. The existing {} test uses an empty notification array, which returns before this access. Please default or migrate maxNotifications and test {} with a non-empty stored notification.

  2. now.isAfter(start) && now.isBefore(end) excludes the exact start time and can never match an overnight window such as 22:00–06:00, although cht-conf PR #826 accepts it. Please either support overnight windows with defined boundary semantics and tests, or reject/document them in cht-conf. A focused test should cover the exact start, exact end, and both sides of midnight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fire notifications during times when CHW is working

4 participants