Skip to content

test: Add non-platform stop to parent station in reconstructed alert test #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbie-sundstrom merged 2 commits into from
Jun 11, 2026
+17 −44
Merged

test: Add non-platform stop to parent station in reconstructed alert test #3103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2036f63
test: Add non-platform stop to parent station in reconstructed alert …
robbie-sundstrom Jun 10, 2026
d530a49
add missing alias
robbie-sundstrom Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 17 additions & 44 deletions test/screens/v2/candidate_generator/widgets/reconstructed_alert_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,17 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
vehicle_type: :subway
}

malden_center_non_platform = %Stop{
Comment thread
rwaskiewicz marked this conversation as resolved.
id: "node-945-platform",
name: "Malden Center - Non-platform Stop",
location_type: 3
}

malden_center_parent = %Stop{
id: "place-mlmnl",
name: "Malden Center",
location_type: 1,
child_stops: [malden_center_nb, malden_center_sb]
child_stops: [malden_center_nb, malden_center_sb, malden_center_non_platform]
}

alerts = [
Expand Down Expand Up @@ -173,6 +179,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
happening_now_active_period: happening_now_active_period,
malden_center_nb: malden_center_nb,
malden_center_sb: malden_center_sb,
malden_center_parent: malden_center_parent,
oak_grove_nb: oak_grove_nb,
oak_grove_sb: oak_grove_sb,
fetch_alerts_fn: fn _ -> {:ok, alerts} end,
Expand All @@ -196,7 +203,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
oak_grove_sb: oak_grove_sb,
oak_grove_nb: oak_grove_nb,
malden_center_sb: malden_center_sb,
malden_center_nb: malden_center_nb
malden_center_parent: malden_center_parent
} = context

alerts = [
Expand All @@ -220,14 +227,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
id: "2",
effect: :station_closure,
informed_entities: [
ie(
stop: %Stop{
id: "place-mlmnl",
name: "Malden Center",
location_type: 1,
child_stops: [malden_center_sb, malden_center_nb]
}
),
ie(stop: malden_center_parent),
ie(stop: malden_center_sb)
],
active_period: happening_now_active_period
Expand Down Expand Up @@ -282,14 +282,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
id: "2",
effect: :station_closure,
informed_entities: [
ie(
stop: %Stop{
id: "place-mlmnl",
name: "Malden Center",
location_type: 1,
child_stops: [malden_center_sb, malden_center_nb]
}
),
ie(stop: malden_center_parent),
ie(stop: malden_center_sb)
],
active_period: [{~U[2020-12-31T00:00:00Z], ~U[2021-01-02T00:00:00Z]}]
Expand Down Expand Up @@ -544,6 +537,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
oak_grove_nb: oak_grove_nb,
malden_center_sb: malden_center_sb,
malden_center_nb: malden_center_nb,
malden_center_parent: malden_center_parent,
fetch_location_context_fn: fetch_location_context_fn,
fetch_alerts_fn: fetch_alerts_fn,
x_fetch_stop_name_fn: x_fetch_stop_name_fn
Expand Down Expand Up @@ -590,14 +584,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
id: "2",
effect: :station_closure,
informed_entities: [
ie(
stop: %Stop{
id: "place-mlmnl",
name: "Malden Center",
location_type: 1,
child_stops: [malden_center_nb, malden_center_sb]
}
),
ie(stop: malden_center_parent),
ie(stop: malden_center_nb),
ie(stop: malden_center_sb)
],
Expand Down Expand Up @@ -710,8 +697,8 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
happening_now_active_period: happening_now_active_period,
fetch_stop_name_fn: fetch_stop_name_fn,
fetch_location_context_fn: fetch_location_context_fn,
malden_center_nb: malden_center_nb,
malden_center_sb: malden_center_sb
malden_center_sb: malden_center_sb,
malden_center_parent: malden_center_parent
} = context

alerts = [
Expand All @@ -725,14 +712,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
id: "2",
effect: :station_closure,
informed_entities: [
ie(
stop: %Stop{
id: "place-mlmnl",
name: "Malden Center",
location_type: 1,
child_stops: [malden_center_sb, malden_center_nb]
}
),
ie(stop: malden_center_parent),
ie(stop: malden_center_sb)
],
active_period: happening_now_active_period
Expand All @@ -757,14 +737,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.ReconstructedAlertTest do
id: "2",
effect: :station_closure,
informed_entities: [
ie(
stop: %Stop{
id: "place-mlmnl",
name: "Malden Center",
location_type: 1,
child_stops: [malden_center_sb, malden_center_nb]
}
),
ie(stop: malden_center_parent),
ie(stop: malden_center_sb)
],
active_period: [{~U[2020-12-31T00:00:00Z], ~U[2021-01-02T00:00:00Z]}]
Expand Down
Loading