fix: Full closure at Symphony showing as partial in reconstructed_alert#3102
Merged
Conversation
rwaskiewicz
approved these changes
Jun 10, 2026
| # finds the corresponding platform names for those child stops included. | ||
| with [informed_parent_station] <- Alert.informed_parent_stations(alert), | ||
| [_ | _] = child_platforms <- informed_parent_station.stop.child_stops, | ||
| [_ | _] = child_platforms <- |
Contributor
There was a problem hiding this comment.
Is there a test that we can write for this change that covers filtering to subway/light rail platforms here before determining the closure type?
Contributor
Author
There was a problem hiding this comment.
yes, but I wanted to get this fix in quickly since this alert is active. Could add a quick unit test for this case later
Contributor
Author
There was a problem hiding this comment.
Added modifications to the tests here: #3103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: Bug: "skipping n platforms" alert message
For the reconstructed alert, we're not filtering down to just Subway platforms before checking if it's a partial closure.